Repository navigation
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 87.96% 87.86% -0.10%
==========================================
Files 43 43
Lines 3896 3899 +3
Branches 995 997 +2
==========================================
- Hits 3427 3426 -1
- Misses 271 273 +2
- Partials 198 200 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalizing a vanity number containing a line terminator currently converts its letters to keypad digits even though Java drops those letters. For example,
Normalize("1800FLOWERS\n")returns18003569377in C# and1800in Java. This is a P2 parity defect with high confidence, affecting callers of normalization with copied or multiline input.The string and StringBuilder guards now reject the five line terminators excluded by Java's non-DOTALL
VALID_ALPHA_PHONE_PATTERN: LF, CR, NEL, line separator and paragraph separator. Ordinary spaces, tabs, vertical tabs and form feeds continue to allow vanity conversion. The additional scan runs only after finding three ASCII letters; no regex or public API is added.Java reference: PhoneNumberUtil.java at 33be5664343676b27761213d8f5500d682568ea7, specifically
VALID_ALPHA_PHONE_PATTERNandnormalize(StringBuilder)at lines 804–811. The existing normalization tests are in the correspondingPhoneNumberUtilTest.java.Validation:
1800, actual18003569377, and pass afterward.dotnet test csharp/PhoneNumbers.slnx: 1,008 tests passed (453 library + 51 extensions tests on each of net8.0 and net10.0).dotnet build csharp --no-restore: all three library TFMs built, zero warnings/errors, including trim/AOT analyzers.PhoneNumberWorkflowBenchmark.ParseOnlyover 1,000 numbers: 358.6 / 335.5 microseconds, 348.12 KB allocated in both. Five measured iterations, one launch each; broad timing intervals overlap, so this is a limited regression check, not evidence of a speedup or of vanity-specific throughput.CI=trueandVersionPrefix=9.0.42; all three packaged DLL hashes match across both builds.core.whitespace=cr-at-eol, preserving the files' existing line endings.Review baselines: C# main
dcaee5a42ab993d26a4bac47ef1cac4f1150ade2; Java master33be5664343676b27761213d8f5500d682568ea7. The C# metadata is v9.0.42 and Java's checked-in metadata is v9.0.41; these comparisons do not consult metadata. This review does not establish whole-library parity. No Java source or generated metadata changed.